Tests: tweaks for PHPUnit 10.x compatibility #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial tweaks to make the tests compatible with PHPUnit 10.x, which enforces a `mixed` return type for the `TestCase::runTest()` method. To test the TestListener, prior to PHPUnit 7.0, overloading the `runTest()` method works best, but as of PHPUnit 10.0, the `runTest()` method has a `mixed` return type declaration (PHP 8.0+). However, since PHPUnit 7.0, testing the TestListener also works when the test name with which the `TestCase` is instantiated is not `runTest()`. So either way, the fixtures used for the TestListener tests need to be duplicated and have two variations. Now the choice was which option to choose: * Duplicate the classes and add a return type to the `runTest()` method. * Duplicate the classes and rename the test method. I investigated both options and have decided to implement option 2 as `void` is not accepted as covariant with `mixed` and these methods are all `void` methods, so adding `mixed` as the return type would be misrepresenting the functionality. The toggle for which test class to load for the various tests has been implemented with a helper method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial tweaks to make the tests compatible with PHPUnit 10.x, which enforces a
mixedreturn type for theTestCase::runTest()method.To test the TestListener, prior to PHPUnit 7.0, overloading the
runTest()method works best, but as of PHPUnit 10.0, therunTest()method has amixedreturn type declaration (PHP 8.0+).However, since PHPUnit 7.0, testing the TestListener also works when the test name with which the
TestCaseis instantiated is notrunTest().So either way, the fixtures used for the TestListener tests need to be duplicated and have two variations.
Now the choice was which option to choose:
runTest()method.I investigated both options and have decided to implement option 2 as
voidis not accepted as covariant withmixedand these methods are allvoidmethods, so addingmixedas the return type would be misrepresenting the functionality.The toggle for which test class to load for the various tests has been implemented with a helper method.